✨ 학생회 회의록 페이지 구현 #320
Merged
✨ 학생회 회의록 페이지 구현 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeolyi
reviewed
Feb 25, 2025
components/common/Attachments.tsx
Outdated
| @@ -2,11 +2,21 @@ import { Attachment } from '@/apis/types/attachment'; | |||
| import Clip from '@/public/image/clip.svg'; | |||
|
|
|||
| // TODO: 여러 맥락에서 사용되므로 마진 prop으로 건네주기 | |||
There was a problem hiding this comment.
마진 prop 추가했으니까 주석 빼도 되겠다
Suggested change
| // TODO: 여러 맥락에서 사용되므로 마진 prop으로 건네주기 |
근데 이 컴포넌트 이번에 작업한 부분에서 썼어?
There was a problem hiding this comment.
아 CouncilAttachment 만들어지기 전에 작업하던 거 그대로 남은듯,,, councilattachment로 대체해서 이번에 쓰인 곳은 없어!
그래도 마진이랑 패딩 프롭은 남겨둘게!
yeolyi
reviewed
Mar 1, 2025
utils/formData.ts
Outdated
There was a problem hiding this comment.
https://wafflestudio.slack.com/archives/C056KQCJHT7/p1740449579111529 여기서 키 값 통일해달라고 요청했는데 잘 통일됐으면 여기 수정사항 없어도 될 듯! 맞다면 롤백하고 머지 ㄱㄱ
yeolyi
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 요약
상세 내용
테스트 방법
참고 문서